Skip to content

Conversation

@JonatanAntoni
Copy link
Member

@JonatanAntoni JonatanAntoni commented Feb 21, 2025

Blocked until this repo is public
Requires a secret reporter id from CodeClimate to be stored in CC_TEST_REPORTER_ID

Fixes

Changes

Screenshots

Checklist

@jreineckearm
Copy link
Collaborator

CC_TEST_REPORTER_ID should be added now. But I believe CI still fails because of no coverage generated with Jest. There are no real tests yet. And we may have to add --coverage=true to the test script.

@JonatanAntoni JonatanAntoni marked this pull request as ready for review February 25, 2025 15:46
Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@JonatanAntoni JonatanAntoni merged commit 22a32e1 into main Feb 25, 2025
10 checks passed
@JonatanAntoni JonatanAntoni deleted the codeclimate branch February 25, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants