Skip to content

Conversation

@jreineckearm
Copy link
Collaborator

Fixes

Changes

  • Updated LICENSE file to include info about redistributables and their licenses
  • Added separate files for each involved license
  • Updated other TPIP docs

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm jreineckearm requested review from KeilChris and jkrech July 11, 2025 12:40
@jreineckearm
Copy link
Collaborator Author

jreineckearm commented Jul 11, 2025

@KeilChris , @jkrech , could you please review the changes in detail.
We may have to rearrange the files depending on how this shows in VS Code/on the marketplace.

@qltysh
Copy link

qltysh bot commented Jul 11, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

KeilChris
KeilChris previously approved these changes Jul 11, 2025
Copy link
Collaborator

@KeilChris KeilChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreineckearm
Copy link
Collaborator Author

fix for failing CI comes with #388

jkrech
jkrech previously approved these changes Jul 11, 2025
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - minor comment.

@jkrech jkrech dismissed stale reviews from KeilChris and themself via b4e9073 July 11, 2025 16:47
Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm
Copy link
Collaborator Author

@jkrech , @KeilChris , could I please get another approval on this one? Previous was dismissed by updates after it.

Copy link
Collaborator

@KeilChris KeilChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreineckearm jreineckearm merged commit f060d55 into main Jul 14, 2025
15 checks passed
@jreineckearm jreineckearm deleted the license-updates branch July 14, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants