Skip to content

Conversation

@jreineckearm
Copy link
Collaborator

@jreineckearm jreineckearm commented Jul 17, 2025

Fixes

Changes

  • Fixing condition under which to show the warning that built-in tools are not present in extension installation.
  • Slightly refine warning message, should never be visible in healthy user installation.
  • Without the fix, you were able to see warning notifications popping up in the bottom right if you used an absolute path for gdb or pyocd in the launch config. Even if the paths were valid and connections happened.

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Jul 17, 2025

All good ✅

@qltysh
Copy link

qltysh bot commented Jul 17, 2025

Diff Coverage: The code coverage on the diff in this pull request is 100.0%.

Total Coverage: This PR will increase coverage by 0.36%.

File Coverage Changes
Path File Coverage Δ Indirect
src/debug-configuration/gdbtarget-configuration-provider.ts -2.8
src/debug-configuration/subproviders/pyocd-configuration-provider.ts 1.2
src/desktop/tool-path-utils.ts 100.0
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm
Copy link
Collaborator Author

@thorstendb-ARM , would you mind a review?

Copy link
Collaborator

@thorstendb-ARM thorstendb-ARM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreineckearm
Copy link
Collaborator Author

@soumeh01 , looks like qlty check timed out/failed again. Are there known issues with these services? It looks like it recovers on rerun.

@jreineckearm jreineckearm merged commit ce76541 into main Jul 21, 2025
15 of 16 checks passed
@jreineckearm jreineckearm deleted the gh-407 branch July 21, 2025 08:15
@soumeh01
Copy link
Collaborator

@soumeh01 , looks like qlty check timed out/failed again. Are there known issues with these services? It looks like it recovers on rerun.

Nothing that I am aware of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants