-
Notifications
You must be signed in to change notification settings - Fork 8
Rework download-tools to use vsce-helper #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reworks the download-tools script to use the @open-cmsis-pack/vsce-helper library, replacing custom implementation with a more standardized approach. The changes modernize the TypeScript execution environment and simplify the tool downloading logic.
Key Changes
- Replaces custom download and extraction logic with
@open-cmsis-pack/vsce-helperlibrary - Migrates from
ts-nodetotsxfor TypeScript execution - Removes custom file download implementation in favor of library-provided functionality
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/download-tools.ts | Complete rewrite using vsce-helper library with simplified asset downloading |
| scripts/file-download.ts | Removed custom download implementation |
| package.json | Updated dependencies and script commands to use tsx instead of ts-node |
| scripts/package.json | Added ES module configuration |
| scripts/*.ts | Updated shebang lines to use tsx |
d4eadf7 to
b1a1353
Compare
|
Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff. Total Coverage: This PR will not change total coverage. 🛟 Help
|
|
A local run failed until I added this line to my Would you expect this to be needed? If so, we should update Important: you need to clean caches after a successful run with workarounds/fixes. Also, I saw trouble running the tool download locally on Windows. Looked like what I saw before which made me move to the other unzipper for Windows. But went away on subsequent runs. Scary but looks like no real problem. |
True, this needs to be added. |
5ce7576 to
2178014
Compare
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes
Changes
Screenshots
Checklist