Skip to content

Conversation

@JonatanAntoni
Copy link
Member

Fixes

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@JonatanAntoni JonatanAntoni requested a review from Copilot July 24, 2025 07:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reworks the download-tools script to use the @open-cmsis-pack/vsce-helper library, replacing custom implementation with a more standardized approach. The changes modernize the TypeScript execution environment and simplify the tool downloading logic.

Key Changes

  • Replaces custom download and extraction logic with @open-cmsis-pack/vsce-helper library
  • Migrates from ts-node to tsx for TypeScript execution
  • Removes custom file download implementation in favor of library-provided functionality

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
scripts/download-tools.ts Complete rewrite using vsce-helper library with simplified asset downloading
scripts/file-download.ts Removed custom download implementation
package.json Updated dependencies and script commands to use tsx instead of ts-node
scripts/package.json Added ES module configuration
scripts/*.ts Updated shebang lines to use tsx

@qltysh
Copy link

qltysh bot commented Jul 24, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jreineckearm
Copy link
Collaborator

A local run failed until I added this line to my .npmrc

@open-cmsis-pack:registry=https://npm.pkg.github.com

Would you expect this to be needed? If so, we should update DEVELOPMENT.MD.

Important: you need to clean caches after a successful run with workarounds/fixes.

Also, I saw trouble running the tool download locally on Windows. Looked like what I saw before which made me move to the other unzipper for Windows. But went away on subsequent runs. Scary but looks like no real problem.

@JonatanAntoni
Copy link
Member Author

A local run failed until I added this line to my .npmrc

@open-cmsis-pack:registry=https://npm.pkg.github.com

Would you expect this to be needed? If so, we should update DEVELOPMENT.MD.

True, this needs to be added.

@JonatanAntoni JonatanAntoni marked this pull request as ready for review August 6, 2025 07:54
Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jreineckearm jreineckearm merged commit 5a033ad into main Aug 6, 2025
18 checks passed
@jreineckearm jreineckearm deleted the vsce-helper branch August 6, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants