-
Notifications
You must be signed in to change notification settings - Fork 8
Initial unit test framework #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26272f6 to
21b743a
Compare
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this and bringing test coverage up to a baseline while the repo size is still manageable to catch up with!
Only discussion point is whether we want to show the Code Climate badges on the VS Code Marketplace/in VS Code which will happen if we don't strip them from the README before/during packaging.
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements! Will merge as is. But create another PR to remove the badges before packaging. Not keen on showing code climate reports on the marketplace or in the VS Code extension manager at this point. Yet, I like to see the stats on the repo itself.
Fixes
Changes
Screenshots
Checklist