Skip to content

Conversation

@jreineckearm
Copy link
Collaborator

@jreineckearm jreineckearm commented Aug 11, 2025

Fixes

Changes

  • Extracts Pname list from cbuild-run processors.
  • Extracts Pname from debug config name. Unfortunately not much opportunity for config name validation due to free-form character of debug config names in templates.
  • Select SVD file based on Pname match, otherwise use first and warn of more than one SVD file.

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Aug 11, 2025

Diff Coverage: The code coverage on the diff in this pull request is 90.9%.

Total Coverage: This PR will increase coverage by 1.67%.

File Coverage Changes
Path File Coverage Δ Indirect
src/cbuild-run/cbuild-run-reader.ts -2.1
src/debug-configuration/subproviders/base-configuration-provider.ts 24.0
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

processor list in cbuild-run

Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
extended tests for multi-core case
tests for SVD file selection based on pname

Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm jreineckearm marked this pull request as ready for review August 12, 2025 13:47
@jreineckearm jreineckearm requested a review from omarArm August 12, 2025 13:47
Signed-off-by: Jens Reinecke <[email protected]>
@jkrech jkrech changed the title Extrace Pname from debug config name to select correct SVD file Extract Pname from debug config name to select correct SVD file Aug 12, 2025
Copy link
Collaborator

@omarArm omarArm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@jreineckearm jreineckearm merged commit 0fe51bf into main Aug 13, 2025
17 checks passed
@jreineckearm jreineckearm deleted the 439-pname-for-svd branch August 13, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants