Skip to content

Conversation

@soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Sep 3, 2025

Changes

  • ${{ github.head_ref }} will look for the feature-branch in the target repository, not the contributor’s fork. If the branch doesn’t exist in the target repo, checkout shall fail when contributed from forks. Instead, use the merge ref for the PR, i.e., “base branch ⨉ PR branch merged”
  • Updated ignore list of workflows to prevent redundant runs

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Sep 3, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

jreineckearm
jreineckearm previously approved these changes Sep 3, 2025
Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note that I fixed MD032 on #491 . So, can possibly keep enabled.
Let's merge #491 first, then merge here. Should reduce the PR to the yml file changes.

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jreineckearm jreineckearm merged commit 35a885c into main Sep 3, 2025
18 checks passed
@jreineckearm jreineckearm deleted the checkout-corrections branch September 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants