-
Notifications
You must be signed in to change notification settings - Fork 8
Refactoring as preparation for periodic refresh timer #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jens Reinecke <[email protected]>
|
Diff Coverage: The code coverage on the diff in this pull request is 94.5%. Total Coverage: This PR will decrease coverage by 0.14%. File Coverage Changes
🛟 Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors stack trace handling by moving request/response tracking from CpuStates into GDBTargetDebugTracker and introducing a consolidated SessionStackTrace event.
- Introduces SessionStackTrace interface and replaces separate request/response events with a single onStackTrace event.
- Migrates stack trace request bookkeeping from CpuStates to GDBTargetDebugTracker.
- Simplifies CpuStates by removing per-session stack trace maps and updating handler logic.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/features/cpu-states/cpu-states.ts | Updates to consume unified SessionStackTrace event and remove local request/response tracking. |
| src/features/cpu-states/cpu-states.test.ts | Adjusts tests to reflect new consolidated stack trace event; removes request/response helpers. |
| src/debug-session/gdbtarget-debug-tracker.ts | Adds tracking and emission of SessionStackTrace, refactors message handling into smaller methods. |
| src/debug-session/gdbtarget-debug-tracker.test.ts | Updates tests to validate new onStackTrace behavior instead of separate request/response events. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Jens Reinecke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Jens Reinecke <[email protected]>
omarArm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes
Changes
Screenshots
Checklist