Skip to content

Conversation

@jreineckearm
Copy link
Collaborator

@jreineckearm jreineckearm commented Oct 13, 2025

Fixes

Changes

  • Code refactoring.
  • Move stacktrace request/response logic from feature/view to tracker.

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm jreineckearm requested a review from Copilot October 13, 2025 05:43
@qltysh
Copy link

qltysh bot commented Oct 13, 2025

Diff Coverage: The code coverage on the diff in this pull request is 94.5%.

Total Coverage: This PR will decrease coverage by 0.14%.

File Coverage Changes
Path File Coverage Δ Indirect
src/debug-session/gdbtarget-debug-tracker.ts 0.2
src/features/cpu-states/cpu-states-history.ts -1.1
src/features/cpu-states/cpu-states.ts -0.5
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors stack trace handling by moving request/response tracking from CpuStates into GDBTargetDebugTracker and introducing a consolidated SessionStackTrace event.

  • Introduces SessionStackTrace interface and replaces separate request/response events with a single onStackTrace event.
  • Migrates stack trace request bookkeeping from CpuStates to GDBTargetDebugTracker.
  • Simplifies CpuStates by removing per-session stack trace maps and updating handler logic.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/features/cpu-states/cpu-states.ts Updates to consume unified SessionStackTrace event and remove local request/response tracking.
src/features/cpu-states/cpu-states.test.ts Adjusts tests to reflect new consolidated stack trace event; removes request/response helpers.
src/debug-session/gdbtarget-debug-tracker.ts Adds tracking and emission of SessionStackTrace, refactors message handling into smaller methods.
src/debug-session/gdbtarget-debug-tracker.test.ts Updates tests to validate new onStackTrace behavior instead of separate request/response events.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm jreineckearm requested a review from Copilot October 13, 2025 05:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm jreineckearm requested a review from omarArm October 13, 2025 06:45
Copy link
Collaborator

@omarArm omarArm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreineckearm jreineckearm merged commit e4cd97b into main Oct 13, 2025
15 checks passed
@jreineckearm jreineckearm deleted the refactoring branch October 13, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants