Skip to content

Conversation

@jreineckearm
Copy link
Collaborator

Fixes

Changes

  • Adds periodic refresh timer to GDBTargetDebugSession.
  • Refresh timer handling in debug tracker.
  • Refresh timer usage with CPU Time Info.

Note: Use J-Link for testing.

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Signed-off-by: Jens Reinecke <[email protected]>
…d event to come, start-stop-start sequence when it sends continued event doesn't hurt).

Stop Refresh Timer on exit/terminate,

Signed-off-by: Jens Reinecke <[email protected]>
@jreineckearm jreineckearm requested a review from Copilot October 13, 2025 07:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a periodic refresh timer system for GDB debug sessions to enable automatic updates of CPU time information during debugging. The refresh timer is designed to work specifically with J-Link for testing.

  • Adds PeriodicRefreshTimer class to manage periodic refresh operations per debug session
  • Integrates refresh timer lifecycle management with debug session events (continued/stopped/terminated)
  • Updates CPU states handling to support both event-driven and periodic refresh patterns

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/debug-session/periodic-refresh-timer.ts New timer class implementing periodic refresh functionality with configurable intervals
src/debug-session/gdbtarget-debug-session.ts Integrates refresh timer into debug sessions and enables it for auxiliary GDB configurations
src/debug-session/gdbtarget-debug-tracker.ts Manages timer lifecycle based on debug events (start/stop/terminate)
src/features/cpu-states/cpu-states.ts Refactors CPU state updates to support periodic refresh and adds refresh event handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@qltysh
Copy link

qltysh bot commented Oct 13, 2025

Diff Coverage: The code coverage on the diff in this pull request is 94.0%.

Total Coverage: This PR will increase coverage by 0.25%.

File Coverage Changes
Path File Coverage Δ Indirect
src/debug-session/gdbtarget-debug-session.ts 0.2
src/debug-session/gdbtarget-debug-tracker.ts 0.4
src/debug-session/periodic-refresh-timer.ts 100.0
src/features/cpu-states/cpu-states.ts 0.2
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@jreineckearm jreineckearm requested a review from Copilot October 13, 2025 08:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jreineckearm jreineckearm marked this pull request as ready for review October 13, 2025 08:55
@jreineckearm jreineckearm requested a review from omarArm October 13, 2025 08:55
Copy link
Collaborator

@omarArm omarArm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, the timer is being updated periodically in the AUX mode

@jreineckearm jreineckearm merged commit 067059a into main Oct 14, 2025
15 checks passed
@jreineckearm jreineckearm deleted the periodic-refreshs branch October 14, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants