-
Notifications
You must be signed in to change notification settings - Fork 8
Periodic Refresh Timer per Session and and use with CPU Time Info #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jens Reinecke <[email protected]>
…d event to come, start-stop-start sequence when it sends continued event doesn't hurt). Stop Refresh Timer on exit/terminate, Signed-off-by: Jens Reinecke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a periodic refresh timer system for GDB debug sessions to enable automatic updates of CPU time information during debugging. The refresh timer is designed to work specifically with J-Link for testing.
- Adds
PeriodicRefreshTimerclass to manage periodic refresh operations per debug session - Integrates refresh timer lifecycle management with debug session events (continued/stopped/terminated)
- Updates CPU states handling to support both event-driven and periodic refresh patterns
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/debug-session/periodic-refresh-timer.ts | New timer class implementing periodic refresh functionality with configurable intervals |
| src/debug-session/gdbtarget-debug-session.ts | Integrates refresh timer into debug sessions and enables it for auxiliary GDB configurations |
| src/debug-session/gdbtarget-debug-tracker.ts | Manages timer lifecycle based on debug events (start/stop/terminate) |
| src/features/cpu-states/cpu-states.ts | Refactors CPU state updates to support periodic refresh and adds refresh event handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Diff Coverage: The code coverage on the diff in this pull request is 94.0%. Total Coverage: This PR will increase coverage by 0.25%. File Coverage Changes
🛟 Help
|
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Jens Reinecke <[email protected]>
Signed-off-by: Jens Reinecke <[email protected]>
omarArm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it, the timer is being updated periodically in the AUX mode
Fixes
Changes
Note: Use J-Link for testing.
Screenshots
Checklist