Skip to content

Conversation

@soumeh01
Copy link
Collaborator

@soumeh01 soumeh01 commented Oct 15, 2025

To clarify the rationale for disabling the package manager cache:

  • The GitHub Action controls how often the cache is created, and we cannot configure the frequency.
  • GitHub does not automatically clean up old caches, which can lead to excessive storage growth.
  • Additionally, caching provides minimal performance benefit during builds.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@qltysh
Copy link

qltysh bot commented Oct 15, 2025

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 requested a review from jreineckearm October 15, 2025 14:26
@soumeh01 soumeh01 marked this pull request as ready for review October 15, 2025 14:32
Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
I agree with the he low benefit of caching, saw some experiments of yours yesterday and was 20 seconds or so. Let's turn it off until the downloads and installation become a real performance problem.

@soumeh01 soumeh01 merged commit 1a7bafb into main Oct 16, 2025
16 checks passed
@soumeh01 soumeh01 deleted the cache-cleanup branch October 16, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants