-
Notifications
You must be signed in to change notification settings - Fork 8
Add a Live Watch Window for the debug extension #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I manually tested the following:
P.s. I chose the icon Known issues:
|
|
Thanks, @omarArm ! Could you please add two or three screenshots to the PR description to give people an impression of how this is going to look like without a need to install a PR build? |
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Haven't tested yet, focused on code review only so far.
Please work through the feedback. Most critical being the ones around saving the expressions to a global state, not a workspace one. And how you use the flag to cancel ongoing refresh...in combination with onRefresh not always being awaited.
|
Diff Coverage: The code coverage on the diff in this pull request is 92.0%. Total Coverage: This PR will decrease coverage by 0.17%. File Coverage Changes
🛟 Help
|
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding those tests. Let's improve from here with smaller increments.
Fixes
Changes
Here you can see in the first screenshot the LiveWatch view before starting a debug session.

Here you can see there is a value visible in the LiveWatch window even though the debug session is in a running state

Checklist