Skip to content

Conversation

@omarArm
Copy link
Collaborator

@omarArm omarArm commented Oct 20, 2025

Fixes

Changes

  • Added a live watch window that gets updated every 500ms

Here you can see in the first screenshot the LiveWatch view before starting a debug session.
image

Here you can see there is a value visible in the LiveWatch window even though the debug session is in a running state
image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@omarArm
Copy link
Collaborator Author

omarArm commented Oct 20, 2025

I manually tested the following:

  1. update is happening almost every 500ms
  2. when paused, the latest value in the live watch window is consistent with that of the actual expression in the vscode builtin watch window
  3. when shutting down the debug session the value is updated to "No active session" for all expressions
  4. when starting a debug session the values of expressions are initialised in accordance to whatever an evaluateRequest returns

P.s. I chose the icon Rocket for the view container at random as a placeholder, it doesn't really mean anything and it should be changed once we have something fixed

Known issues:

  1. For some reason if I keep on pressing the resume button in the debug window continuously, the builtin watch window gets updated with every click, while the Live Watch window doesn't, I am still investigating

@jreineckearm
Copy link
Collaborator

Thanks, @omarArm ! Could you please add two or three screenshots to the PR description to give people an impression of how this is going to look like without a need to install a PR build?

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Haven't tested yet, focused on code review only so far.
Please work through the feedback. Most critical being the ones around saving the expressions to a global state, not a workspace one. And how you use the flag to cancel ongoing refresh...in combination with onRefresh not always being awaited.

@qltysh
Copy link

qltysh bot commented Oct 22, 2025

Diff Coverage: The code coverage on the diff in this pull request is 92.0%.

Total Coverage: This PR will decrease coverage by 0.17%.

File Coverage Changes
Path File Coverage Δ Indirect
src/features/cpu-states/cpu-states.ts 0.1
src/views/live-watch/live-watch.ts 91.6
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Collaborator

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding those tests. Let's improve from here with smaller increments.

@jreineckearm jreineckearm merged commit 8c0a7ee into main Oct 23, 2025
15 checks passed
@jreineckearm jreineckearm deleted the addNewTreeView branch October 23, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants