Skip to content

Modeling - fix crash by ignore invalid TessellatedShell#668

Closed
wsw0108 wants to merge 4 commits into
Open-Cascade-SAS:masterfrom
wsw0108:wsw0108-patch-1
Closed

Modeling - fix crash by ignore invalid TessellatedShell#668
wsw0108 wants to merge 4 commits into
Open-Cascade-SAS:masterfrom
wsw0108:wsw0108-patch-1

Conversation

@wsw0108
Copy link
Copy Markdown

@wsw0108 wsw0108 commented Aug 12, 2025

fix #667

fix Open-Cascade-SAS#667

Signed-off-by: Shiwei Wang <4977975+wsw0108@users.noreply.github.com>
@dpasukhi
Copy link
Copy Markdown
Member

dpasukhi commented Aug 12, 2025

The recommended patch will be create an empty array all the time.
I will analyze the ReadSubList implementation and probably will go with true return always (for all STEP entities)

Signed-off-by: Shiwei Wang <4977975+wsw0108@users.noreply.github.com>
Signed-off-by: Shiwei Wang <4977975+wsw0108@users.noreply.github.com>
Signed-off-by: Shiwei Wang <4977975+wsw0108@users.noreply.github.com>
@dpasukhi
Copy link
Copy Markdown
Member

dpasukhi commented Aug 13, 2025

My apologies, I will fix that issue during current or next week.
Current fix is not optimal and I would fix issue for rest 1000 files :)

Thank you for your contribution. Current issue is more complicated and I would avoid some workaround on place.
If you will have something more to contribute - we always welcome.

@wsw0108 wsw0108 closed this Aug 14, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Closed in Maintenance Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

Crash when loading step file with invalid entity TESSELLATED_SHELL

2 participants