Skip to content

Data Exchange, STP - Crash on empty list#671

Merged
dpasukhi merged 2 commits into
Open-Cascade-SAS:IRfrom
dpasukhi:step_null_array
Aug 16, 2025
Merged

Data Exchange, STP - Crash on empty list#671
dpasukhi merged 2 commits into
Open-Cascade-SAS:IRfrom
dpasukhi:step_null_array

Conversation

@dpasukhi
Copy link
Copy Markdown
Member

Added condition to always allocate an object in case of empty list

Added condition to always allocate an object in case of empty list
@dpasukhi dpasukhi requested a review from Copilot August 14, 2025 10:33
@dpasukhi dpasukhi self-assigned this Aug 14, 2025
@dpasukhi dpasukhi added the 1. Data Exchange Import/Export or iterating of the CAD data label Aug 14, 2025
@dpasukhi dpasukhi linked an issue Aug 14, 2025 that may be closed by this pull request
@dpasukhi
Copy link
Copy Markdown
Member Author

dpasukhi commented Aug 14, 2025

Dear @wsw0108 could you please check that patch?

@wsw0108
Copy link
Copy Markdown

wsw0108 commented Aug 14, 2025

Dear @wsw0108 could you please check that patch?

OK. I will check this tomorrow or next week.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@wsw0108
Copy link
Copy Markdown

wsw0108 commented Aug 15, 2025

@dpasukhi With this patch, 7.9.1 can ReadFile(file with illegal TessellatedShell line) correctly.

@dpasukhi dpasukhi merged commit afccf69 into Open-Cascade-SAS:IR Aug 16, 2025
23 checks passed
@dpasukhi dpasukhi deleted the step_null_array branch August 16, 2025 08:24
@github-project-automation github-project-automation Bot moved this from Todo to Done in Maintenance Aug 16, 2025
dpasukhi added a commit that referenced this pull request Sep 6, 2025
Added condition to always allocate an array in case of empty list
dpasukhi added a commit that referenced this pull request Sep 6, 2025
Added condition to always allocate an array in case of empty list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. Data Exchange Import/Export or iterating of the CAD data

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Crash when loading step file with invalid entity TESSELLATED_SHELL

3 participants