Coding - Dangerous use of 'cin'#681
Merged
Merged
Conversation
Refactor input buffer allocation to use constexpr for improved readability and safety
dpasukhi
added
2. Enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR addresses security concerns with dangerous use of std::cin by refactoring input buffer allocation to use constexpr variables and setting stream width limits. The changes improve code safety by preventing potential buffer overflows when reading user input.
Key Changes
- Replaced hardcoded buffer sizes with
constexpr size_t aBufferSizeconstants - Added
width()calls to input streams before reading to prevent buffer overflows - Applied consistent buffer size management across multiple input operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Draw/TKXSDRAWIGES/XSDRAWIGES/XSDRAWIGES.cxx | Updated 4 instances of std::cin usage with constexpr buffer sizes and width limits |
| src/Draw/TKTopTest/GeometryTest/GeometryTest_ConstraintCommands.cxx | Updated file input stream usage with constexpr buffer size and width limit |
| src/DataExchange/TKXSBase/IFSelect/IFSelect_Functions.cxx | Updated std::cin usage with constexpr buffer size and width limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor input buffer allocation to use constexpr for improved readability and safety