Mesh - Stack overflow when meshing#695
Merged
Merged
Conversation
…pen-Cascade-SAS#688 Fixed stack overflow by introducing StackOfFrames class that allows for iterative approach instead of recursive.
dpasukhi
reviewed
Aug 29, 2025
|
|
||
| // Try to infect neighbor nodes | ||
| IMeshData::VectorOfInteger aVictimNodes; | ||
| // std::list<Standard_Integer> aVictimNodes; |
dpasukhi
added
2. Bug
dpasukhi
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a stack overflow issue in the BRepMesh_Delaun meshing algorithm by replacing recursive calls with an iterative approach. The fix prevents stack overflow when processing large or deeply nested mesh structures.
Key changes:
- Introduced
StackOfFramesclass to manage processing frames iteratively instead of recursively - Modified
killTrianglesAroundVertexmethod to collect victim nodes in a provided container rather than recursively processing them - Replaced recursive depth-first traversal with iterative processing using the new stack-based approach
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| BRepMesh_Delaun.hxx | Added theVictimNodes parameter to killTrianglesAroundVertex method signature |
| BRepMesh_Delaun.cxx | Implemented StackOfFrames class and refactored polygon cleanup to use iterative processing |
dpasukhi
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed stack overflow by introducing StackOfFrames class that allows for iterative approach instead of recursive.