Occt 793#886
Closed
dpasukhi wants to merge 17 commits into
Closed
Conversation
…scade-SAS#738) Fixed nullptr dereference
Performed a basic refactoring of BRepFill_SectionPlacement::Perform() and fixed a crash.
- Refactored helper functions with clearer naming and improved parameter handling - Added null safety checks to prevent crashes when edge lookup fails in face topology - Removed debug code and simplified variable declarations for better maintainability
…dShapes is missing (Open-Cascade-SAS#760) Check Acces.Root().FindAttribute(...) result in TNaming_Tool::NamedShape and return an empty Handle if the TNaming_UsedShapes attribute is not found to avoid using an uninitialized map.
…en-Cascade-SAS#830 Parametric space of TopoDS_Face and ElSLib::ConeVIso() are now used for calculating parameters. Scale factor is pre-applied.
…ascade-SAS#859) - Refactored the `ReorderFaces` function to iterate through all edges at a vertex instead of assuming only two edges exist - Replaced manual face swapping with `std::swap` for cleaner code - Removed debug output statements and unused debug declarations
- Added null checks for 2D curve handles to prevent dereferencing null geometry - Refactored `ProcessDE()` to use modern C++ idioms (auto, structured bindings, range-based iteration patterns) - Simplified `FindPaveBlocks()` using a lambda function to reduce code duplication
…-SAS#875) - Modified parameter validation to allow curves where `theUFirst > theULast` within `Precision::Confusion()` tolerance - Updated documentation to reflect the new tolerance-based validation - Added comprehensive test suites for both 2D and 3D curve adaptors
- Added null safety checks for `BRepAdaptor_Curve2d::Curve()` before evaluating curve parameters - Modernized variable declarations with `const` qualifiers - Replaced conditional assignment with `std::min` for cleaner code
…de-SAS#864) - Introduced a separate temporary allocator (`aTmpAllocator`) for per-iteration collections - Reorganized collection declarations to distinguish between temporary (per-iteration) and persistent (cross-iteration) data structures - Added allocator reset logic at the start of each iteration to reclaim memory
Constructor of BRepTopAdaptor_FClass2d is updated to guarantee processing of curves with large parameters values with small difference between them.
Refactor shell construction algorithm for improved performance: - Add GetConnectedFaceGroups function using DFS to identify topologically connected face groups before shell construction - Replace O(nˆ3) iterations with pre-built connectivity maps (FaceEdgesMap, EdgeFacesMap) using STL unordered_map with custom allocators for O(1) lookup. - Process only the largest connected component first, significantly reducing time complexity for large face sets
…AS#753) Fixed issue with unstable shape order after fixing. Fixed reference data which was changed
…AS#769) Second iteration of fixing regressions. Fixed issue with loops and incorrect shell created. Open-Cascade-SAS#584 affected some tests which were not updated on time. Now all test cases are passed.
Add .github/workflows/build-windows-packages.yml to build and package OCCT on Windows. Workflow downloads 3rd-party archives, builds Release/Debug variants with and without PCH, applies GitHub attestation to DLLs, and uploads individual and combined artifacts.
- Bump OCCT version from 7.9.2 to 7.9.3. - Refactor file handling in the workflow to use Rename-Item instead of Copy-Item for better clarity and efficiency. - Update artifact paths to include the new version in the filenames. - Fix env.bat THIRDPARTY_DIR path for Debug builds to use a relative path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.