Conversation
soxofaan
approved these changes
Oct 19, 2021
Member
|
To be honest, I wasn't aware that 501 should have been used for unsupported endpoints at back-end and client side. |
Member
Author
|
@flahn conformed via chat that this is not an issue for R. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #415 for details.
Strictly speaking, this is a breaking change, but in reality, all clients (afaik) handle 404 well enough as most back-ends return 404s instead of 501s for unsupported back-ends. Therefore a check from all client devs (Py, R, JS) would be appreciated.