Skip to content

Vector data cubes#441

Merged
m-mohr merged 11 commits into
draftfrom
vector-cubes
Jan 30, 2023
Merged

Vector data cubes#441
m-mohr merged 11 commits into
draftfrom
vector-cubes

Conversation

@m-mohr

@m-mohr m-mohr commented Feb 23, 2022

Copy link
Copy Markdown
Member

Minor additions to the API only, Mostly reflecting the changes in stac-extensions/datacube#10 and the addition to the JSON Schema for the new datacube subtype.

@m-mohr m-mohr added this to the 1.2.0 milestone Feb 23, 2022
@m-mohr m-mohr self-assigned this Feb 23, 2022
@soxofaan

Copy link
Copy Markdown
Member

The proposed name for the vector dimension is "geometry". We also had "vector" in mind as an alternative. Opinions?

GeoPandas also uses "geometry" by default for the column that contains the vector data, so "geometry" will sound conceptually familiar to people that know GeoPandas

@m-mohr
m-mohr marked this pull request as ready for review November 7, 2022 13:55
@m-mohr

m-mohr commented Nov 7, 2022

Copy link
Copy Markdown
Member Author

This is ready for final review.

…parameters, returns, dimensions) and their relation to subtypes
Comment thread openapi.yaml

@soxofaan soxofaan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve (with minor remark)

Comment thread openapi.yaml Outdated
@m-mohr

m-mohr commented Jan 18, 2023

Copy link
Copy Markdown
Member Author

This is also ready for final review. There are some issues with the relevant tooling (redoc), so I can't express everything 1:1 in the API spec. The name for the vector dimension is now "geometries" (plural) in accordance with "bands", okay?

@soxofaan @mkadunc @aljacob @clausmichele @jdries @dthiex @LukeWeidenwalker @pierocampa

@m-mohr
m-mohr requested a review from dthiex January 18, 2023 15:32
@soxofaan

Copy link
Copy Markdown
Member

The name for the vector dimension is now "geometries" (plural) in accordance with "bands", okay?

I don't think that changing to plural "geometries" is really necessary. Apart from "bands", all dimension types and names are/look singular: "spatial", "temporal", "x", "y", "other".

As another data point here: geopandas uses singular "geometry" as column type and name in data frames, e.g. see https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoDataFrame.html#geopandas.GeoDataFrame

@m-mohr

m-mohr commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

I don't think that changing to plural "geometries" is really necessary.

Are you saying

       * `geometries` for dimensions of type `geometries`

should change to

      * `geometry` for dimensions of type `geometries`

?

@soxofaan

Copy link
Copy Markdown
Member

I guess so.

If I understand correctly, the dimension type has already been settled on plural "geometries" in merged PR stac-extensions/datacube#10
so in this PR #441 there is only room to change the dimension name to singular "geometry", which would indeed not look very consistent in the recommendation

* name `geometry` for dimensions of type `geometries`

Sidenote: I noticed that @aljacob made related comment at Open-EO/openeo-processes#382 (review)

@m-mohr

m-mohr commented Jan 30, 2023

Copy link
Copy Markdown
Member Author

In principle we can still change everything as we just merged the PRs yet, but we have not released anything yet (including the STAC extension). Anyway, I'm merging this now and will then create a separate issue for this. Makes it easier to work on further improvements.

#479

@m-mohr
m-mohr merged commit 749bfc7 into draft Jan 30, 2023
@m-mohr
m-mohr deleted the vector-cubes branch January 30, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants