feat(converter): carry tip penetration and contact diameter into imported twig disks - #5
Open
TableflipFoundry wants to merge 2 commits into
Open
feat(converter): carry tip penetration and contact diameter into imported twig disks#5TableflipFoundry wants to merge 2 commits into
TableflipFoundry wants to merge 2 commits into
Conversation
Mirrors native twigBuilder: the shared twig disk profile now stamps penetrationMm from the tip defaults so imported twigs honor the universal contact-disc penetration setting. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Twig disk joint standoff now receives contactDiameterMm so the tip-ball clearance floor (contact radius + 0.1 mm) applies to imported twig disks the same as native ones. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small converter changes supporting the DragonFruit contact-disc upgrade (universal tip penetration + oval contact face):
penetrationMm, so twig tips embed into the model like natively placed supports.twigDiskJointStandoffnow receivescontactDiameterMm, so the new tip-ball clearance floor (contact radius + 0.1 mm) applies to imported twig disks the same as native ones.Merge order
Merge this PR before Open-Resin-Alliance/DragonFruit
feat/contact-disc-upgrade— that branch bumps the submodule pointer to this branch tip.🤖 Generated with Claude Code