Dedupe orchestrator/consumer_agent validation, note consumer_agent in docs - #9
Merged
Merged
Conversation
… docs Follow-up to #8. The C8 validator block copy-pasted the orchestrator's instructions-file and tools checks; extracted the shared shape into _validate_instructions_block so a future fix only has one place to land. Also updated the KNOWN_TOOLS comment and the two "what a domain pack supplies" descriptions (README, module docstring) to mention the optional consumer_agent, which they'd missed. No behavior change: validate_domain.py --self-test still passes 18/18 and --all still passes for every base and domain pack. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uFYqCFPpYZ32CCCEbwZeD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8
Non-blocking cleanup items flagged in review of #8, addressed here:
validate_domain.py's orchestrator/consumer_agent validation. Both blocks ran the identical instructions-file (exists inside domain dir, readable, non-empty) and tools (allowlist + group-slug-naming) checks, copy-pasted with only string renames. Extracted the shared shape into_validate_instructions_block(...), called once fororchestratorand once forconsumer_agent. Behavior is unchanged — only the orchestrator's "no tools" warning and its extra hint on a missing file stayed distinct, via parameters.KNOWN_TOOLScomment, which still said "for its orchestrator" after C8 addedconsumer_agentas a second thing it gates.README.mdand thevalidate_domain.pymodule docstring — both still listed only corpus group / orchestrator / equivalences, missing the optionalconsumer_agentC8 added.Validation
No schema or behavior change — this is a readability/consistency pass over #8's diff.
Generated by Claude Code