Version 12.3 by Yuri05 · Pull Request #2877 · Open-Systems-Pharmacology/OSPSuite.Core

Yuri05 · 2026-05-31T18:31:42Z

Description

Merge develop ➡️ main before release.

Type of change

Please mark relevant options with an x in the brackets.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires documentation changes (link at least one user or developer documentation issue):
Algorithm update - updates algorithm documentation/questions/answers etc.
Other (please describe): Merge develop ➡️ main before release.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Integration tests
Unit tests
Manual tests
No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

Check if the code is well documented
Check if the behavior is what is expected
Check if the code is well tested
Check if the code is readable and well formatted
Additional checks (document below if any)
Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

* update 12.2 -> 12.3 * Update OSPSuite.Core.sln Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update minor * remove version from file names * revert file rename * fix sln file --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* use upstream workflow * wrong version number * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* #2720 bug for updating curves on graphic * #2720 prevent different colors * #2720 link data to simulations wrong behavior * #2720 remove using

* #2714 export history to csv * #2714 formatting * #2714 format * #2714 extension and formatting

* add test sdk * add ignore attribute * Update tests/OSPSuite.UI.Tests/OSPSuite.UI.Tests.csproj Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix up --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

…rs for SAs (especially) and PIs (#2741) * Fixes #2740 Include possibility of filtering by User-defined parameters for SAs (especially) and PIs * Apply suggestions from code review Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* #2745 display name for building blocks * Update src/OSPSuite.Presentation/Mappers/DiffItemToDiffItemDTOMapper.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…r views that do not support hierarchical (#2748)

* Fixes #2731 Follow up on CoPilot suggestions * change 0 test * pr feedback * we already had that one! * rename for double too

…2751) * Fixes #2750 When cloning a CurveChart most properties are not cloned * greptile feedback * add a comment * using not needed

… results to Simulation" in combination with "Use as factor" (#2755)

* Fixes #2739 PI options not visible on small screens * Update src/OSPSuite.UI/Views/ParameterIdentifications/CategorialParameterIdentificationRunModeView.cs Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

…color (#2757)

* Fixes #2760 Add validation of Nan and Inf parameters at t=0 * refactory names and id's in tests * modify requirement for braces in all loops/conditionals * pr feedback * change the object type resolver call * update xml doc

…2764) * Fixes #1863 remove check for monotonically increasing time values? * add a comment * pr feedback * pr feedback * simplify * reduce iteration * simplify

* Fixes #2767 Make preview option sticky in projects * pr feedback

- Updated interface signature to include throwIfNotFound parameter - Modified implementation to throw exception when path not found and flag is true - Added warning log when path not found and flag is false - Updated all existing usages to pass throwIfNotFound: false for backward compatibility - Added test cases for the new behavior Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com>

Check for non-zero quantities first and return early after adding them, rather than checking for zero quantities. This makes the code cleaner and follows better practices. Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com>

The test was failing because OutputSelections wasn't set up on the faked ISimulation object. Now properly returns a new OutputSelections instance when accessed. Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com>

…hrow-if-not-found-argument Add throwIfNotFound parameter to AddQuantitiesToSimulationOutputByPath

* Initial plan * Fix TableFormula error message to show existing Y value Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> * Improve test assertion to ensure exception is thrown Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> * Use existing constructor with existingPoint instead of adding new overload Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com> * refactor the test to make it compile and work. * add a comment in the test. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com>

* Initial plan * Add ImportPopulationFromCsvString method to PopulationTask Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> * Refactor CSV readers and importer to eliminate code duplication Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com> * refactor to reduce copy/paste * pr feedback --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PavelBal <25903040+PavelBal@users.noreply.github.com> Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com>

* #1717 autoreducetolerance * Update SimulationBatch.cs * Update SimulationRunOptions.cs * Update SimulationRunOptions.cs * #1717 fix tests

* Fixes #2814 Cancelled PI does not show Number of Evaluations * pr feedback

* #1541 importer error forwarded * #1541-Fix PR Comments Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

…ext menu after a PI was started (#2837)

…k-sim (#2835) * Fixes #2834 Separator Selector is styled differently and pops-under pk-sim * pr feedback

* Fixes #2838 Distributed parameter overwrite loses distribution When a distributed parameter is overwritten via an individual parameter that provides both DistributionType and Value, keep the parameter distributed (with its formula and sub-parameters) and apply the value as a fixed value, rather than collapsing it to a plain parameter. ParameterFactory.CreateDistributedParameter now pre-creates the sub-parameters referenced by the distribution formula (Mean, Deviation, Percentile, ...) so the parameter is operational even when the spatial structure does not provide them. * Move value setting into ParameterValueToParameterMapper Apply parameterValue.Value inside the mapper so callers receive a fully-formed parameter: - distributed: parameter.Value setter is invoked, which keeps the distribution formula intact, sets IsFixedValue=true and updates the percentile sub-parameter. - plain: the value is forwarded to ParameterFactory.CreateParameter so the resulting constant formula carries the value directly. Removed a now-redundant unit test that duplicated the existing distributed-parameter-with-no-value coverage. * Honor the value parameter in CreateDistributedParameter The factory now applies the provided value as a fixed value on the distributed parameter (via the Value setter), matching how CreateParameter already turns a provided value into a constant formula. This makes the API symmetric and allows ParameterValueToParameterMapper to forward the value through the factory in both branches instead of treating the distributed case specially. * Refresh distributed parameter percentile after sub-parameters are set When QuantityValuesUpdater processes the individual parameters of a distributed parameter, the parent's value (and percentile) is applied before its sub-parameters (Mean/Deviation/...) are updated. The percentile is therefore initially cached against placeholder defaults. Add a second pass that calls RefreshPercentile() on every distributed parameter that came from the individual and is marked IsFixedValue, so the cached percentile reflects the correct sub-parameter values. Verified with the existing When_a_distributed_parameter_value_is_overwritten_via_an_individual_parameter_and_the_parameter_is_not_in_the_spatial_structure test, which now also asserts the recomputed percentile.

coderabbitai · 2026-05-31T18:31:48Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)

v13
V13
develop
feature/overwrite_parameter_set
feature/event_protocol

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 392d83d7-8298-4aea-be9f-39cb68abf241

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

rwmcintosh and others added 30 commits January 14, 2026 11:02

Use upstream workflow (#2733)

34e0822

* use upstream workflow * wrong version number * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

2720 link data to simulations wrong behavior (#2735)

8a0213c

* #2720 bug for updating curves on graphic * #2720 prevent different colors * #2720 link data to simulations wrong behavior * #2720 remove using

#2714 export history to csv (#2734)

fab1f2e

* #2714 export history to csv * #2714 formatting * #2714 format * #2714 extension and formatting

#2737 fix test (#2738)

d789fa5

#2743 initial conditions creator value set to 0 (#2744)

cab8ce3

#2714 restore icon (#2742)

2adfaea

Fixes #2747 Introduce a new parameter layout enumeration for paramete…

6ecda5e

…r views that do not support hierarchical (#2748)

Fixes #2731 Follow up on CoPilot suggestions (#2749)

1699e95

* Fixes #2731 Follow up on CoPilot suggestions * change 0 test * pr feedback * we already had that one! * rename for double too

Fixes #2750 When cloning a CurveChart most properties are not cloned (#…

5d5cf8f

…2751) * Fixes #2750 When cloning a CurveChart most properties are not cloned * greptile feedback * add a comment * using not needed

Adding some basic claude rules. No code change so pushing straing to dev

470e24c

Fixes #2754 Parameter Identification: erroneous behavior of "Transfer…

e00e28b

… results to Simulation" in combination with "Use as factor" (#2755)

Fixes #2752 Closing and opening a simulation causes curves to change …

b012842

…color (#2757)

Fixes #1863 remove check for monotonically increasing time values? (#…

cf6e02f

…2764) * Fixes #1863 remove check for monotonically increasing time values? * add a comment * pr feedback * pr feedback * simplify * reduce iteration * simplify

Fixes #2767 Make preview option sticky in projects (#2768)

db6ece2

* Fixes #2767 Make preview option sticky in projects * pr feedback

Initial plan

f99869c

Fix test by properly mocking OutputSelections

2421dc0

The test was failing because OutputSelections wasn't set up on the faked ISimulation object. Now properly returns a new OutputSelections instance when accessed. Co-authored-by: rwmcintosh <261477+rwmcintosh@users.noreply.github.com>

update test to use mocks

eee5c84

reduce wordiness

f15d8b8

Merge pull request #2776 from Open-Systems-Pharmacology/copilot/add-t…

29d6113

…hrow-if-not-found-argument Add throwIfNotFound parameter to AddQuantitiesToSimulationOutputByPath

#2650 reload with same settings fails (#2774)

4c2368c

rwmcintosh and others added 7 commits March 3, 2026 13:48

Fixes #2787 Add OutputPath meta data to observed data imports (#2789)

58978ee

#1717 autoreducetolerance (#2773)

9133367

* #1717 autoreducetolerance * Update SimulationBatch.cs * Update SimulationRunOptions.cs * Update SimulationRunOptions.cs * #1717 fix tests

Fixes #2814 Cancelled PI does not show Number of Evaluations (#2815)

ad3be31

* Fixes #2814 Cancelled PI does not show Number of Evaluations * pr feedback

#1541 importer error forwarded (#2813)

b2cf131

* #1541 importer error forwarded * #1541-Fix PR Comments Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Fixes #2836 Run (and some other actions) are not disabled in the cont…

763ddbe

…ext menu after a PI was started (#2837)

Fixes #2834 Separator Selector is styled differently and pops-under p…

4475595

…k-sim (#2835) * Fixes #2834 Separator Selector is styled differently and pops-under pk-sim * pr feedback

Yuri05 requested review from msevestre and rwmcintosh May 31, 2026 18:32

rwmcintosh approved these changes Jun 1, 2026

View reviewed changes

Yuri05 merged commit 1a3cef6 into main Jun 1, 2026
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Version 12.3#2877

Version 12.3#2877
Yuri05 merged 37 commits into
mainfrom
develop

Yuri05 commented May 31, 2026

Uh oh!

coderabbitai Bot commented May 31, 2026

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Yuri05 commented May 31, 2026

Description

Type of change

How Has This Been Tested?

Reviewer checklist

Screenshots (if appropriate):

Questions (if appropriate):

Uh oh!

coderabbitai Bot commented May 31, 2026

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants