[backend/frontend] feat(stix): introduce platform affinity (#4517) #4685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
github-actions
bot
added
the
filigran team
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
antoinemzs
changed the title
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4685 +/- ##
============================================
+ Coverage 50.57% 50.74% +0.17%
- Complexity 3708 3737 +29
============================================
Files 903 908 +5
Lines 26819 26936 +117
Branches 2012 2018 +6
============================================
+ Hits 13563 13669 +106
- Misses 12437 12445 +8
- Partials 819 822 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }) | ||
| public class AssetGroup implements Base { | ||
|
|
||
| public Map<Endpoint.PLATFORM_TYPE, Map<Endpoint.PLATFORM_ARCH, String>> wellKnown() { |
| @Transient | ||
| private final ResourceType resourceType = ResourceType.TAG_RULE; | ||
|
|
||
| public void setTag(Tag tag) { |
Member
There was a problem hiding this comment.
It feels a bit odd to block a parent entity based on a child entity. Just a personal impression.
| @Table(name = "tag_rules") | ||
| @EntityListeners(ModelBaseListener.class) | ||
| public class TagRule implements Base { | ||
| public static Set<String> RESERVED_TAG_NAMES = |
Member
There was a problem hiding this comment.
Relative to the Tag, so it should be placed on the Tag entity, right?
| @RequiredArgsConstructor | ||
| public class InitStarterPackCommandLineRunner implements CommandLineRunner { | ||
| @Slf4j | ||
| public class V20260101_Starter_pack extends DataPack { |
Member
There was a problem hiding this comment.
This is our new way to run starter pack feature right ?
| ResourcePatternResolver resolver) { | ||
| super(dataPackService); | ||
| this.settingRepository = settingRepository; | ||
| this.tagRuleRepository = tagRuleRepository; |
| } | ||
| } | ||
| // Force opencti tag | ||
| labels.add(OPENCTI_TAG_NAME); |
Member
There was a problem hiding this comment.
Should we keep OpenCTI as the source for security coverage ?
| assetGroup.setName("All %s %s".formatted(platform.toString(), arch.toString())); | ||
| assetGroup.setDynamicFilter(filterGroup); | ||
|
|
||
| AssetGroup saved = this.assetGroupService.createAssetGroup(assetGroup); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Testing Instructions
Related issues
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...