Skip to content

Conversation

@GaetanSantucci
Copy link
Member

Inject failed if we create one with a expectation's name longer than 255 characters, we need to block this.

Proposed changes

Implementation of double front-end and back-end validation to prevent entries exceeding 255 characters in the input name field

Testing Instructions

Steps to create the smallest reproducible scenario:

Create a simulation
Create a mail inject in it with a manual expectation with a name longer than 255 characters
Launch the simulation, the inject is executed but with an error and with the PARTIAL status

Related issues

Further comments

The remaining challenge will be to better manage the backend return error for a display that's better than a 500 error, but that will require a comprehensive platform-wide effort.

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 12, 2026
@GaetanSantucci GaetanSantucci changed the title Backend security, frontend comfort, data integrity [frontend/backend] feat(simulation): fix inject name longer (#4635) Jan 12, 2026
@GaetanSantucci GaetanSantucci force-pushed the issue/4635-fix-inject-name-longer branch from 77c54a8 to b914402 Compare January 12, 2026 16:37
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.58%. Comparing base (c7c716f) to head (b914402).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4723      +/-   ##
============================================
+ Coverage     50.57%   50.58%   +0.01%     
- Complexity     3708     3711       +3     
============================================
  Files           903      903              
  Lines         26820    26820              
  Branches       2012     2012              
============================================
+ Hits          13564    13568       +4     
+ Misses        12437    12435       -2     
+ Partials        819      817       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants