[frontend/backend] feat(simulation): fix inject name longer (#4635) #4723
+22
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject failed if we create one with a expectation's name longer than 255 characters, we need to block this.
Proposed changes
Implementation of double front-end and back-end validation to prevent entries exceeding 255 characters in the input name field
Testing Instructions
Steps to create the smallest reproducible scenario:
Create a simulation
Create a mail inject in it with a manual expectation with a name longer than 255 characters
Launch the simulation, the inject is executed but with an error and with the PARTIAL status
Related issues
Further comments
The remaining challenge will be to better manage the backend return error for a display that's better than a 500 error, but that will require a comprehensive platform-wide effort.