-
-
Notifications
You must be signed in to change notification settings - Fork 177
fix(#758): add path.join to build os-dependent java binary path #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mok-liee
wants to merge
66
commits into
OpenAPITools:master
Choose a base branch
from
mok-liee:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
dbb010b
support JAVA_HOME environment variable
adnbrownie b430560
Merge branch 'master' into patch-2
mok-liee ac4a81c
test(generator-cmd): add consideration of the JAVA_HOME variable
mok-liee f96430c
docs: add instructions for the use of JAVA_HOME
mok-liee ce2ac4c
fix: add quotes to accept spaces in the JAVA_HOME path
mok-liee a5724ae
fix: add quotation marks only for windows paths
mok-liee 00fda13
ci: add windows-latest to build workflow
mok-liee 25fb817
ci: add windows condition to test script
mok-liee 2371c0a
fix: use path.join for generating java bin path
mok-liee a708d4b
Merge branch 'master' into patch-2
mok-liee 5f0dbf8
fix: add surrounding quotation marks for the whole concurrently command
mok-liee 8c3eb47
fix: remove quotation marks for non-windows systems
mok-liee 7538ffa
Merge branch 'patch-2' into feature/add-windows-to-build
mok-liee 15956c1
chore(windows-build): try powershell commands
mok-liee 9a23c8a
chore(windows-build): try powershell commands
mok-liee c39ef8a
chore(windows-build): switch to Java 17 on windows build
mok-liee 960b21e
chore(windows-build): add test case without JAVA_HOME
mok-liee 15ac43e
chore(config.service): use process-cwd() for windows
mok-liee 2a9aef9
Revert "support JAVA_HOME environment variable (#756)" (#761)
wing328 7e43a4e
feat(release): trigger a release
wing328 805bb0b
Merge pull request #2 from mok-liee/feature/add-windows-to-build
mok-liee 04007fd
chore(windows-build): remove JAVA_HOME env var correctly
mok-liee 34dd0de
chore(deps): update dependency prettier to v3 (#749)
renovate[bot] 4042a6e
chore(deps): update dependency @types/jest to v29.5.12 (#755)
renovate[bot] 2092e90
chore(deps): update dependency jest-environment-jsdom to v29 (#748)
renovate[bot] b115451
chore(deps): update dependency ts-jest to v29.1.2 (#764)
renovate[bot] fcb2f83
chore(deps): update commitlint monorepo to v19 (#744)
renovate[bot] ad97182
feat(release): trigger a release
wing328 f980618
chore(deps): update dependency dotenv to v16.4.5 (#767)
renovate[bot] bcd1ff6
chore(deps): update dependency eslint to ~8.57.0 (#768)
renovate[bot] 2178d3c
support JAVA_HOME environment variable (#756)
mok-liee 583bde9
chore(deps): update dependency @types/lodash to v4.17.0 (#769)
renovate[bot] bc85db4
chore(deps): update nrwl monorepo to v17.3.2 (#771)
renovate[bot] 4b058b6
chore(deps): update dependency @commitlint/cli to v19.2.0 (#772)
renovate[bot] f6dcb95
fix(deps): update dependency reflect-metadata to v0.2.1 (#773)
renovate[bot] 7f41abc
chore(deps): update dependency husky to v9 (#774)
renovate[bot] c042887
chore(deps): update dependency type-fest to v4 (#775)
renovate[bot] 1d2a1a2
feat(#644): add cli option for openapitools.json (#754)
nicholasphair fb01b0b
Revert "fix(deps): update dependency reflect-metadata to v0.2.1 (#773…
wing328 7787f07
fix(app): configure http with proxy url if present in environment (#762)
jontze 5dff424
fix(deps): update dependency axios to v1.6.8 (#766)
renovate[bot] 5f00242
chore(deps): update commitlint monorepo to v19.2.2 (#778)
renovate[bot] 37597a2
fix(deps): update dependency @nestjs/axios to v3.0.2 (#765)
renovate[bot] 76dfb19
Update README.md with JDK version required
wing328 6b76bbb
Update README.md with openjdk
wing328 18abce4
fix(deps): update dependency axios to v1.7.4 [security] (#789)
renovate[bot] 67f6457
update versions mentioned in Readme (#795)
wing328 45e1633
docs: how to use local JARs and `SNAPSHOT`builds. (#794)
joscha 41585e7
support JAVA_HOME environment variable
adnbrownie bc9352d
test(generator-cmd): add consideration of the JAVA_HOME variable
mok-liee 1a94743
docs: add instructions for the use of JAVA_HOME
mok-liee 26cde5d
fix: add quotes to accept spaces in the JAVA_HOME path
mok-liee 47b0abb
fix: add quotation marks only for windows paths
mok-liee 55ad5be
ci: add windows-latest to build workflow
mok-liee aadd8ed
ci: add windows condition to test script
mok-liee 2dc0c8e
fix: use path.join for generating java bin path
mok-liee 5eb3b82
fix: add surrounding quotation marks for the whole concurrently command
mok-liee 9d8c2f6
fix: remove quotation marks for non-windows systems
mok-liee 4c35653
chore(windows-build): try powershell commands
mok-liee 29f99a6
chore(windows-build): try powershell commands
mok-liee adc00ea
chore(windows-build): switch to Java 17 on windows build
mok-liee f08c18f
chore(windows-build): add test case without JAVA_HOME
mok-liee f17d771
chore(config.service): use process-cwd() for windows
mok-liee 78e6f06
chore(windows-build): remove JAVA_HOME env var correctly
mok-liee 55be5d0
support JAVA_HOME environment variable (#756)
mok-liee 4aba432
Merge branch 'patch-2' of https://github.com/mok-liee/openapi-generat…
mok-liee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if
command
contains"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the generated commands already have
"
inside and only run successfully with these quotes in the windows build and without it will not.concurrently
expects it in this case if there are spaces in the paths, which is very common in windows. therefore i would generalize this.i was also been able to reproduce the behavior with
concurrently
alone.i can send later some examples.
the most important part of the windows build plan already looks promising. there is only one error in the last step that i can't get locally.
Error: spawn ENAMETOOLONG
sounds really special to me. i think the command is too long. i try to figure out why this is. i mean
foo
is not longer thenbar
😂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got it. i removed the
JAVA_HOME
env wrong. for now all tests are passed.can you tell me how i can resolve the conflicts? why does this not behave like the first PR, where i was able to resolve the conflicts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to cherry-pick 3e949d8, which was reverted by me last week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you test with something like
--additional-properties option="test-double-quote"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tried to cherry-pick but after resolving the conflicts there was nothing to commit. i commited with
git commit --allow-empty
but it will not resolve the conflicts.i try to implement something like this to the test.
on my local env (windows - git bash) the following succeeded: