Skip to content

replaced oltu with scribejava for Java - okhttp client #10965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

valmoz
Copy link
Contributor

@valmoz valmoz commented Nov 25, 2021

#10661

This PR replaces the deprecated Apache Oltu library with ScribeJava for the Java OkHttp client.
It also tries to improve the OAuth code as follows:

  • uniforming the OAuth authentication to the other auth methods, managing the Authentication as a parameter instead of using an OkHttp interceptor;
  • introducing the AuthorizationCode, Password, and ClientCredentials Grants;
  • managing authorization URL, refresh URL, and scope parameters for the oauth2 config.

this replaces #10732

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

@valmoz valmoz closed this Dec 14, 2021
@valmoz valmoz reopened this Dec 14, 2021
@DFromTheHood
Copy link

Can this PR be completed soon?

@RockyMM
Copy link
Contributor

RockyMM commented Sep 13, 2022

Maybe @wing328 or @jmini could take a look?

@valmoz
Copy link
Contributor Author

valmoz commented Sep 13, 2022

I admit that I let this PR die, I didn't have enough time to complete it.
If it is still of interest, I can try to recover it, adapting it to the new versions... I don't know when I'll be able to work on it though

@RockyMM
Copy link
Contributor

RockyMM commented Sep 13, 2022

Ah, too bad, as it is a very welcome improvent. I could maybe dedicate some time in the future for this, but it is very unlikely, I guess we are all in the same boat :D

@hroig
Copy link

hroig commented Jul 20, 2023

Are there any plans to resurrect this branch?

@valmoz
Copy link
Contributor Author

valmoz commented Jul 21, 2023

Hi @hroig
unfortunately I didn't have time to dedicate to it. If I'll be able to find some time during the incoming summer I'll try to complete it, but I can't assure anything.
If somebody wants to try and complete it, it could be a great help.

@chilphil
Copy link

how is it going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants