-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
[csharp-netcore] Adds features for #11010 and #11001 #11015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[csharp-netcore] Adds features for #11010 and #11001 #11015
Conversation
…er request NONCE needs to be added. Adding the RequestOptions as a parameter moves this more inline with the typescript-axios client.
…jection I am configuring the configuration with a singleton scope. This prevents updating the ApiToken eaily when the JWT expires and needs to be refreshed. By adding the GetApiToken producer function it provides an extension point to add the necessary token refresh logic with minimal changes needed to the configuration. The default is to return the AccessToken so existing configurations work.
@RubberChickenParadise can you please resolve the merge conflicts when you've time? If you're using Windows, pleas use Git Bash to run the following (step 3):
let us know if you need any help. |
@wing328 i have resolved the conflicts once already. I can do it again |
@@ -22,7 +22,7 @@ These options may be applied as additional-properties (cli) or configOptions (pl | |||
|prependFormOrBodyParameters|Add form or body parameters to the beginning of the parameter list.| |false| | |||
|sortModelPropertiesByRequiredFlag|Sort model properties to place required parameters before optional parameters.| |true| | |||
|sortParamsByRequiredFlag|Sort method arguments to place required parameters before optional parameters.| |true| | |||
|sourceFolder|source folder for generated code| |OpenAPI/src| | |||
|sourceFolder|source folder for generated code| |OpenAPI\src| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RubberChickenParadise it shouldn't use ''. Please give Git bash (windows) a try to see if this's still repeatable.
# Conflicts: # docs/generators/java.md # docs/generators/ruby.md # samples/client/others/csharp-netcore-complex-files/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClient-ConditionalSerialization/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClient-httpclient/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClient-net47/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClient-net5.0/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClient/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClientCore/.openapi-generator/VERSION # samples/client/petstore/csharp-netcore/OpenAPIClientCoreAndNet47/.openapi-generator/VERSION
@wing328 Getting some build errors with [INFO] |
Adds the features requested in #11010 and #11001 for csharp-netcore client generation
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)