Skip to content

feat: Add types-import missing for go code generator. #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianjungki
Copy link

@jianjungki jianjungki commented Jul 18, 2022

modified AbstractGoCodegen class for go

  • update types-mapping logic for GoCodeGen, remove duplicate imports, and avoiding missing import in code.
  • because const type can't not use self-defined type, so overwrite fromModel func for that.

PR checklist

  • [✔️] Read the contribution guidelines.
  • [✔️] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [✔️] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • [✔️] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [✔️] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

target language: Go
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

@wing328
Copy link
Member

wing328 commented Aug 11, 2022

@jianjungki thanks for the PR. Do you have a minimal spec to reproduce the issue? I think we need to some tests for this change.

@jianjungki
Copy link
Author

@jianjungki thanks for the PR. Do you have a minimal spec to reproduce the issue? I think we need to some tests for this change.

okay, I will add the spec for these problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants