Skip to content

Conversation

@simPod
Copy link
Contributor

@simPod simPod commented Jan 17, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The action name is escaped from ActionName to ``ActionNameOperation. The enum is also exported escaped as ActionNameOperationEnum`.

But currently, enums are then referenced via unescaped name as ActionNameEnum.

@simPod
Copy link
Contributor Author

simPod commented Jan 17, 2023

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks for your contribution.
can you add a test for this?

@simPod
Copy link
Contributor Author

simPod commented Jan 18, 2023

I tried running tests but

./mvnw clean install ends with

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.0:jar (attach-javadocs) on project openapi-generator-core: MavenReportException: Error while generating Javadoc: Project contains Javadoc Warnings -> [Help 1]

and IDE does not show Run test button either
image
so I kinda gave up as I don't know how to setup the project properly.

I've read contributing docs but that did not help with the issue really.

@simPod simPod marked this pull request as ready for review January 23, 2023 14:48
@wing328 wing328 added this to the 7.4.0 milestone Feb 12, 2024
@wing328 wing328 modified the milestones: 7.4.0, 7.5.0 Mar 11, 2024
@wing328 wing328 modified the milestones: 7.5.0, 7.6.0 Apr 17, 2024
@macjohnny macjohnny merged commit 07e5a67 into OpenAPITools:master Mar 24, 2025
14 checks passed
@simPod simPod deleted the enum branch March 24, 2025 13:27
@wing328 wing328 added this to the 7.13.0 milestone Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants