Skip to content

[elixir] elixir generator failing to compile + invalid references #15075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ariesclark
Copy link

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mrmstn, but doubt we'd need their review to merge this.

@ariesclark ariesclark changed the title fix: elixir generator failing to compile + invalid references fix(elixir-client): elixir generator failing to compile + invalid references Mar 29, 2023
@ariesclark
Copy link
Author

ariesclark commented Mar 30, 2023

So, apparently the generator doesn't work at all, even with these changes, annoying...
Models are returned empty, status codes are ignored, responses return things like {:ok, %VRChat.Model.Error%{}}, many models contain references that just don't exist.. [VRChat.Model.String.t()]

To see what I'm experiencing, try generating using this specification:
https://raw.githubusercontent.com/vrchatapi/specification/gh-pages/openapi.yaml

@mrmstn
Copy link
Contributor

mrmstn commented Apr 1, 2023

I am currently on holiday and will review this PR as soon as I return.

In the meantime, please create an issue addressing the problems you are experiencing. To help expedite the resolution process, kindly provide the following information:

  • For incorrect referencing, please specify the property name that contains the erroneous reference. This will help us identify and debug any potential side effects arising from format: or other property details.
  • For issue with the response code mapping, it is crucial to examine the HTTP request from the server. You can capture this by executing curl in verbose mode -v. Please replace your secrets with ***** or something similar.

Additionally, please include snippets from the generated models and API modules, as they will be valuable in understanding the issue.

Thank you for your cooperation and understanding.

@mrmstn mrmstn changed the title fix(elixir-client): elixir generator failing to compile + invalid references [elixir] elixir generator failing to compile + invalid references Apr 1, 2023
@mrmstn mrmstn self-assigned this Apr 1, 2023
@mrmstn mrmstn self-requested a review June 9, 2024 11:50
@efcasado
Copy link
Contributor

efcasado commented May 5, 2025

@mrmstn, @wing328 - This pull request can be closed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants