Skip to content

Fix python code when receiving JSON data without a property that is a… #20022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jorisdobbelsteen
Copy link
Contributor

… dict to ref/enum causing AttributeError

This is a fix for issue #20021.

When sending a json object, where a optional property is not provided by server, and this property is a additionalProperty of a enum/ref type, then it causes an AttributeError.
The AttributeError is due to the property returning None (=get function of dict), while the code expects a dict.

This has been fixed in many places in the code by checking if dict.get("property") is not None. However, this location might have been missed.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Python team: @cbornet @tomplus @krjakbrjak @fa0311 @multani

@wing328
Copy link
Member

wing328 commented Nov 9, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 7.10.0 milestone Nov 9, 2024
@wing328 wing328 modified the milestones: 7.10.0, 7.11.0 Nov 18, 2024
@jorisdobbelsteen
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Hi @wing328,
Thanks very much for the extensive check.
I've updated the author so it should link to the right contributor.

@wing328
Copy link
Member

wing328 commented Dec 2, 2024

thanks for the PR. let's give it a try

@wing328 wing328 merged commit 1eaa75b into OpenAPITools:master Dec 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants