Skip to content

Conversation

@jmartens
Copy link
Contributor

@jmartens jmartens commented Jan 23, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@multani can review?

@jmartens
Copy link
Contributor Author

jmartens commented Jan 23, 2025

This addresses #20464

@wing328
Copy link
Member

wing328 commented Feb 19, 2025

cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@wing328
Copy link
Member

wing328 commented Feb 19, 2025

updated samples/docs via 9ba9a6d

let's see if all tests pass

@wing328
Copy link
Member

wing328 commented Feb 19, 2025

FYI. I pushed cb7da35 to skip blank lines

@wing328 wing328 merged commit 890c37f into OpenAPITools:master Feb 19, 2025
32 of 35 checks passed
@wing328
Copy link
Member

wing328 commented Feb 19, 2025

thanks for the PR, which has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants