Skip to content

Fix HttpRetryManager deprecation warning in Unreal Engine 5.4+ #20605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix HttpRetryManager deprecation warning in Unreal Engine 5.4+ #20605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1625835
Fix FManager deprecation warning
roseatromero Feb 6, 2025
ce69b78
Fix operator
roseatromero Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/openapi-generator/src/main/resources/cpp-ue4/model-base-source.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ namespace {{this}}

bool HttpRetryManager::Tick(float DeltaTime)
{
#if ENGINE_MAJOR_VERSION <= 5 && ENGINE_MINOR_VERSION <= 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This silences the deprecation warning, but it needs to be completed with the full fix: The HttpRetryManager should not be ticking at all, since it no longer needs to call Update.

FManager::Update();
#endif
return true;
}

Expand Down
2 changes: 2 additions & 0 deletions samples/client/petstore/cpp-ue4/Private/OpenAPIBaseModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ namespace OpenAPI

bool HttpRetryManager::Tick(float DeltaTime)
{
#if ENGINE_MAJOR_VERSION <= 5 && ENGINE_MINOR_VERSION <= 3
FManager::Update();
#endif
return true;
}

Expand Down
Loading