-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add flag skipDefaultUserAgent to skip setting user agent in TypeScrip… #20611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag skipDefaultUserAgent to skip setting user agent in TypeScrip… #20611
Conversation
@christophmohr would it be possible to just set |
@macjohnny Do you have in mind to drop the flag entirely and just set an empty User-Agent-header resp. remove it? I've just followed the solution of #20367 suggested by @wing328 |
I'm not quite sure if I get you right, @macjohnny - but setting the I'm still getting the Or do you mean adjusting the code within the mustache-file and setting the User-Agent to
|
are you using the latest snapshot release? |
#20571 was merged only recently |
@christophmohr you can easily test the latest master following the instructions in https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-to-test-with-the-latest-master-of-openapi-generator |
Hi @macjohnny & @wing328 do you have an idea when #20571 will be released? As far as I can see, this change / flag should solve the issue... |
released v7.12.0 please give it a try when you've time |
Thanks guys, It's been fixed with #20571 👍 |
closes #20600
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha