Skip to content

Conversation

@ronreynolds
Copy link
Contributor

added intellij-codestyle.xml file (contains minor annotation-wrapping tweaks to default IntelliJ style) and applied to all .java files (all modules)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@ronreynolds
Copy link
Contributor Author

#20768

@wing328
Copy link
Member

wing328 commented Mar 3, 2025

please resolve the merge conflicts. i'll get it merged first

thanks

@ronreynolds
Copy link
Contributor Author

latest push resolves all merge conflicts with master branch and includes re-apply of code-style to all java files just to be 100% sure. (only CodeGenMojo contained a tiny change)
@wing328

@wing328
Copy link
Member

wing328 commented Mar 3, 2025

the CI failures are not related to this PR

let's give this a try

this may result in many PRs having merge conflicts but it's good to fix code style from time to time.

@wing328 wing328 merged commit 2cff152 into OpenAPITools:master Mar 3, 2025
14 of 16 checks passed
@wing328 wing328 added this to the 7.13.0 milestone Mar 3, 2025
kpy3 pushed a commit to kpy3/openapi-generator that referenced this pull request Mar 13, 2025
…20734)

* added intellij-codestyle.xml and sample of it being applied to some java code-gen classes

* code-format changes ONLY

* few more format changes since last merge with master

* applied code-style to all java one last time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants