fix(openapi-generator): fixes GlobalSettings

[astrologic7]

This pull request aims to fix an issue I've noticed when adding a non-string value or key as a system property.
The issue surfaces during the invocation of CodeMojo#execute.
In such cases, GlobalSettings#log throws a ClassCastException as expected/partially documented here.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[wing328]

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

[astrologic7]

Hi @wing328, thanks to highlighting that. I'm going to fix it asap 👍🏻

[wing328]

can you please review the build failures when you've time?

[astrologic7]

@wing328 could you try to build it again? There was an issue when running on ubuntu that I've fixed. Thanks.

[wing328]

thanks for the fix. looks good to me

[wing328]

can you please take a look at https://github.com/OpenAPITools/openapi-generator/actions/runs/13909102161/job/38919010919?pr=20888 ?

restarting the job seems to "fix" the issue

[astrologic7]

Hi @wing328,
I've tested the codebase multiple times both on Windows and Ubuntu with Jvm 11 and 17 but I'm not able to reproduce the issue. I can see from the Jdk 17 build logs that the following properties are present and printed out:
java.lang.Object@fff3158=test2 test1=java.lang.Object@fff3158
they are those expected to be not null.
There are just a couple of things I find weird:

• In Jdk 17 build assertion fails after having printed out these properties. This order of execution belongs to an old version of this PR: see here while the latest version executes same operations but with a different order: see here.
• In Jdk 11 build I don't see the previous log entries.

Although the object we are referencing is static and final and its address should never change the only thing we can try is to get its address immediately and save it in a constant to use for further searches. If this approach still fails we can think of removing the failing assertions. Let me know if you want to run your pipeline again and see if the error occurs again or if you want to skip this step and try the proposed approach.

[wing328]

just merged #20925 to revise the test a bit

and it seems to fix the issue for other PRs: #20888 (comment)