Skip to content

[Nim] Fix compilation in case of schema with enum constraint with an enum value being not a valid nim identifier #20780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Nim] Fix compilation in case of schema with enum constraint with an enum value being not a valid nim identifier #20780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .../openapi-generator/src/main/java/org/openapitools/codegen/languages/NimClientCodegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,15 +355,21 @@ public String toEnumName(CodegenProperty property) {
}
}

private boolean isValidIdentifier(String identifier) {
//see https://nim-lang.org/docs/manual.html#lexical-analysis-identifiers-amp-keywords
return identifier.matches("^(?:[A-Z]|[a-z]|[\\x80-\\xff])(_?(?:[A-Z]|[a-z]|[\\x80-\\xff]|[0-9]))*$");
}

@Override
public String toEnumVarName(String name, String datatype) {
name = name.replace(" ", "_");
name = StringUtils.camelize(name);

if (name.matches("\\d.*")) { // starts with number
return "`" + name + "`";
} else {
// starts with number or contains any character not allowed,see
if (isValidIdentifier(name)) {
return name;
} else {
return "`" + name + "`";
}
}

Expand Down
Loading