Skip to content

Conversation

jaimesf
Copy link
Contributor

@jaimesf jaimesf commented Mar 4, 2025

Generate multipart Optional params to allow correct compiling with delegate pattern

Fix #9530

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Ping for Java Spring technical committee members as suggested in the checklist: @cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg

@wing328
Copy link
Member

wing328 commented Mar 11, 2025

thanks for the PR. please resolve the merge conflict when you've time

jaimesf added 2 commits March 11, 2025 17:43
# Conflicts:
#	modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java
@jaimesf
Copy link
Contributor Author

jaimesf commented Mar 11, 2025

merge conflicts resolved

@wing328
Copy link
Member

wing328 commented Apr 30, 2025

tested locally to repeat the issue and confirm the fix

thanks for the contribution

@wing328 wing328 merged commit 3c664d1 into OpenAPITools:master Apr 30, 2025
51 of 53 checks passed
@wing328 wing328 added this to the 7.14.0 milestone Apr 30, 2025
@jaimesf jaimesf deleted the fix-spring-multipart-optional-params branch April 30, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][SPRING] multipart/form with optional parameters does not produce "Optional" in API interface, only in API Delagate

3 participants