Discard mapped models with matching explicit discriminator mappings #20939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMrMilchmann
changed the title
Contributor
Author
|
Is there anything missing for this to be considered? |
wing328
reviewed
Jul 2, 2025
| return fmt.Errorf("failed to unmarshal Object as NestedObject2: %s", err.Error()) | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
thanks for the pr
is that expected these code block removed after your fix?
cc @OpenAPITools/generator-core-team
Contributor
Author
There was a problem hiding this comment.
Yes, this is expected. Both NestedObject1 and NestedObject2 have explicit discriminator mappings (ONE and TWO respectively), yet this is mistakenly generated in addition to the generators.
Member
|
thanks again for the pr let's give it a try appreciate the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20938
This fixes the issue by checking if an explicit discriminator has been set already for a model name by checking for equality by model name instead of
MappedModel(which included the mapping name).