Skip to content

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Apr 28, 2025

fix some warnings and update akka, pekko and scala versions.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@xuwei-k xuwei-k force-pushed the akka-pekko-server-fix-warnings branch from 465baf4 to ce6c5da Compare April 28, 2025 11:02
@xuwei-k xuwei-k force-pushed the akka-pekko-server-fix-warnings branch from ce6c5da to 2dbffa0 Compare April 28, 2025 11:16
import {{akkaImportGroupId}}.http.scaladsl.server.Directives._
import {{akkaImportGroupId}}.actor.ActorSystem
import {{akkaImportGroupId}}.stream.ActorMaterializer
import {{akkaImportGroupId}}.stream.Materializer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 14 to 15

Http().bindAndHandle(routes, "0.0.0.0", 9000)
}
Http().newServerAt("0.0.0.0", 9000).bind(routes)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import {{akkaImportGroupId}}.http.scaladsl.unmarshalling.Unmarshaller.UnsupportedContentTypeException

import scala.concurrent.Future
import scala.language.implicitConversions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid warnings

[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:12:16: implicit conversion method _symbol2NR should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] This can be achieved by adding the import clause 'import scala.language.implicitConversions'
[warn] or by setting the compiler option -language:implicitConversions.
[warn] See the Scaladoc for value scala.language.implicitConversions for a discussion
[warn] why the feature should be explicitly enabled.
[warn]   implicit def _symbol2NR(symbol: Symbol): NameReceptacle[String] = new NameReceptacle[String](symbol.name)
[warn]                ^
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:13:16: implicit conversion method _string2NR should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn]   implicit def _string2NR(string: String): NameReceptacle[String] = new NameReceptacle[String](string)
[warn]                ^
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:31:18: implicit conversion method apply should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn]     implicit def apply[T](value: T)(implicit sdef: StringDef[T]): StringMagnet { type Out = sdef.Out } =
[warn]                  ^
[warn] three warnings found

@xuwei-k xuwei-k marked this pull request as ready for review April 28, 2025 11:39
@wing328
Copy link
Member

wing328 commented Apr 29, 2025

cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06)

@chameleon82
Copy link
Contributor

Approved

@wing328 wing328 merged commit 56eb8f7 into OpenAPITools:master Apr 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants