-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
update akka-http and pekko-http server generator and example #21166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update akka-http and pekko-http server generator and example #21166
Conversation
465baf4
to
ce6c5da
Compare
ce6c5da
to
2dbffa0
Compare
import {{akkaImportGroupId}}.http.scaladsl.server.Directives._ | ||
import {{akkaImportGroupId}}.actor.ActorSystem | ||
import {{akkaImportGroupId}}.stream.ActorMaterializer | ||
import {{akkaImportGroupId}}.stream.Materializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActorMaterializer
is deprecated
|
||
Http().bindAndHandle(routes, "0.0.0.0", 9000) | ||
} | ||
Http().newServerAt("0.0.0.0", 9000).bind(routes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bindAndHandle
is deprecated
import {{akkaImportGroupId}}.http.scaladsl.unmarshalling.Unmarshaller.UnsupportedContentTypeException | ||
|
||
import scala.concurrent.Future | ||
import scala.language.implicitConversions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avoid warnings
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:12:16: implicit conversion method _symbol2NR should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] This can be achieved by adding the import clause 'import scala.language.implicitConversions'
[warn] or by setting the compiler option -language:implicitConversions.
[warn] See the Scaladoc for value scala.language.implicitConversions for a discussion
[warn] why the feature should be explicitly enabled.
[warn] implicit def _symbol2NR(symbol: Symbol): NameReceptacle[String] = new NameReceptacle[String](symbol.name)
[warn] ^
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:13:16: implicit conversion method _string2NR should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] implicit def _string2NR(string: String): NameReceptacle[String] = new NameReceptacle[String](string)
[warn] ^
[warn] tmp/samples/server/petstore/scala-pekko-http-server/src/main/scala/org/openapitools/server/StringDirectives.scala:31:18: implicit conversion method apply should be enabled
[warn] by making the implicit value scala.language.implicitConversions visible.
[warn] implicit def apply[T](value: T)(implicit sdef: StringDef[T]): StringMagnet { type Out = sdef.Out } =
[warn] ^
[warn] three warnings found
cc @clasnake (2017/07), @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04) @Fish86 (2023/06) |
Approved |
fix some warnings and update akka, pekko and scala versions.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)