-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
add elixir workflow #21215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add elixir workflow #21215
Conversation
Error: test/format_test.exs:5 can you please have a look at this one too? for the petstore (http request, response test), please ignore those for the time being |
I reverted the change to |
aa00f87
to
19c7c53
Compare
@wing328, I believe the changes are ready to be merged into your branch 🙏 |
what about updating the tests with date/datetime accordingly as these are the causing the test failure? |
We could do that, but that would only hide the actual issue and change the semantics of the test - right? The test is failing because the decoding step is not automatically casting strings to This Alternatively, we could adjust the failing tests here (even it breaks their semantics) in order to get a green build; and use #21216 to re-introduce the old behavior and re-adjust the formatting tests again. What do you think? |
@wing328, all tests are passing now mix test
Running ExUnit with seed: 636492, max_cases: 40
............
Finished in 2.3 seconds (2.3s async, 0.00s sync)
12 tests, 0 failures There are a number of issues with how the Elixir generator approaches testing. For now, I focused on getting a green build to unblock the work you are doing, but I feel the existing tests need to be reviewed and improved. I left some basic observations in the description of this |
agreed there are rooms for improvements some other client generators have moved to Echo API server instead of Petstore server for testing. Elixir client may also consider adding Echo API server tests: https://github.com/OpenAPITools/openapi-generator/wiki/Integration-Tests#echo-server |
* add elixir workflow * update * fix * add elixir workflow (#21215) * update tests to use built-in json module instead of jason * update base_url * temporarily disable type-casting for dates * retry failing tests * update spec to use localhost * add petsore local server to workflow --------- Co-authored-by: Enrique Fernández <[email protected]>
Description
Contributions to #21214 to unblock the work done by @wing328.
This
PR
includes the following fixes:Jason
was replaced by the built-in JSON module in [feat][elixir] use elixir 1.18 built-in json module #21039 but the tests were not updated accordingly.http
on port80
; but it seems things changed at some point and the tests were not updated accordingly.