Skip to content

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 5, 2025

Cpprest has a public U macro definition that causes build errors in libraries as U is a common name for template parameters. This PR fixes the issue by turning it off.

microsoft/cpprestsdk@411a109/Release/include/cpprest/details/basic_types.h#L87

Related to microsoft/cpprestsdk#1805 and fmtlib/fmt#4180

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Cpprest has a public U macro definition that causes build errors in libraries as U is a common name for template parameters. This PR fixes the issue by turning it off.

[microsoft/cpprestsdk@411a109/Release/include/cpprest/details/basic_types.h#L87](https://github.com/microsoft/cpprestsdk/blob/411a109150b270f23c8c97fa4ec9a0a4a98cdecf/Release/include/cpprest/details/basic_types.h#L87)

Related to microsoft/cpprestsdk#1805 and fmtlib/fmt#4180
@aminya aminya force-pushed the cpp-rest-xplaststr branch from 77405b0 to 428ca2d Compare May 5, 2025 09:45
@wing328 wing328 added this to the 7.14.0 milestone May 7, 2025
@wing328
Copy link
Member

wing328 commented May 7, 2025

At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unused-lambda-capture’ may have been intended to silence earlier diagnostics
[ 52%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/SchemaWithSet.cpp.o
[ 56%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/SchemaWithSet_vaccinationBook.cpp.o
[ 60%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/Tag.cpp.o
[ 64%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/User.cpp.o
[ 68%] Building CXX object CMakeFiles/CppRestPetstoreClient.dir/src/model/Vaccine.cpp.o
[ 72%] Linking CXX static library libCppRestPetstoreClient.a

tests passed locally

@wing328 wing328 merged commit 3048fb0 into OpenAPITools:master May 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants