Skip to content

[cpp-rest-sdk] fix enum values being used instead of names #21223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aminya
Copy link
Contributor

@aminya aminya commented May 5, 2025

This fixes the issue with enum values being used instead of enum names. This is problematic when the values contain symbols that can't be a C++ variable.

It also simplifies the enum variables by removing the unnecessary prefix for scoped enum classes.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 7, 2025

can you please resolve the merge conflicts when you've time?

also looks like this is a breaking change

i remember someone added the classname prefix with a reason. need to find out more before we can merge this PR.

update: the change was made a while ago. what about adding an option for fallback?

@aminya
Copy link
Contributor Author

aminya commented May 7, 2025

@wing328 It's a breaking change cause it fixes the issue of using values instead of names. This will not work for any strings that are not symbols, such as numbers or names with dashes or dots.

I don't think we should keep this compatible, as it was broken, and only worked because the tests assumed symbol-like string options. The prefix is unnecessary because in C++, the enum classes are scoped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants