Skip to content

Dart: use lower camel case for values #21228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cantasura
Copy link

@Cantasura Cantasura commented May 6, 2025

Related to this issue
@jaumard

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 7, 2025

is this similar to the enumPropertyNaming option in java client generator?

ref: https://openapi-generator.tech/docs/generators/java/

@Cantasura
Copy link
Author

It looks like that it could be same.
I'm not sure though if the toVarName function of the AbstractCodegen only triggers for enum cases.

@wing328
Copy link
Member

wing328 commented May 7, 2025

I'm not sure though if the toVarName function of the AbstractCodegen only triggers for enum cases.

i think it's used by all variable naming

@wing328
Copy link
Member

wing328 commented May 7, 2025

cc
@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

@kuhnroyal
Copy link
Contributor

Nice new setting! But something seems wrong if there are changes to variable names in existing samples.

@wing328
Copy link
Member

wing328 commented May 9, 2025

here is another PR related to Dart enum naming: #20911

cc @epou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants