-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
Added ANTLR. Fix Issue #20960 #21230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
thanks for the PR please review the build failure when you've time |
modules/openapi-generator/pom.xml
Outdated
@@ -159,6 +159,7 @@ | |||
</executions> | |||
<configuration> | |||
<sourceDirectory>${basedir}/src/test/antlr4</sourceDirectory> | |||
<libDirectory>${basedir}/src/test/antlr4/imports</libDirectory> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about using spaces instead of tabs?
shall we fix the javadoc issue instead of excluding these from the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Day,
I'm not sure what you mean exactly, so please can you help me to clarify?
My main issue comes from the fact that it seems the JavaDoc plugin doesn't recognize the ANTLR packages because the dependency is in test scope.
Are you saying that instead of excluding the generated files from scanning, I should find a way to let them be scanned without also causing classpath issues?
Also, sorry about the inconsistent whitespace, I'll fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main issue comes from the fact that it seems the JavaDoc plugin doesn't recognize the ANTLR packages because the dependency is in test scope.
👌
please ignore my comment on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Tabs removed from the pom files
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)I'm taking inspiration from #3715 by @sullis and #11738 by @borsch to try and add parsing utilities for Kotlin and possibly other languages. For now, though, it's just to fix this issue.
Kotlin Grammar gotten from https://github.com/antlr/grammars-v4
@4brunu, please help review