Skip to content

[php-flight] fix: use static PHPUnit assertions #21253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

[php-flight] fix: use static PHPUnit assertions #21253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/openapi-generator/src/main/resources/php-flight/register_routes_test.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
{{/operations}}
};
\{{invokerPackage}}\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
{{/apis}}
{{#models}}
Expand All @@ -41,7 +41,7 @@ class RegisterRoutesTest extends \PHPUnit\Framework\TestCase {
{{/-first}}
{{/enumVars}}
{{/allowableValues}}
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\{{escapedModelPackage}}\\{{classname}}'),
\{{modelPackage}}\{{classname}}::{{#allowableValues}}{{#enumVars}}{{#-first}}{{{name}}}{{/-first}}{{/enumVars}}{{/allowableValues}}
);
Expand Down
12 changes: 6 additions & 6 deletions samples/server/petstore/php-flight/Test/RegisterRoutesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function addPet(\OpenAPIServer\Model\Pet $pet): \OpenAPIServer\Model\Pet|
}
};
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
public function testRegisterRoutesAbstractStoreApi(): void
{
Expand All @@ -39,7 +39,7 @@ public function deleteOrder(string $orderId): void
}
};
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
public function testRegisterRoutesAbstractUserApi(): void
{
Expand All @@ -49,28 +49,28 @@ public function createUser(\OpenAPIServer\Model\User $user): void
}
};
\OpenAPIServer\RegisterRoutes::registerRoutes($handler);
$this->assertTrue(true);
self::assertTrue(true);
}
public function testParseParamsEnumFindPetsByStatusStatusParameterInner(): void
{
$value = 'available';
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\OpenAPIServer\\Model\\FindPetsByStatusStatusParameterInner'),
\OpenAPIServer\Model\FindPetsByStatusStatusParameterInner::AVAILABLE
);
}
public function testParseParamsEnumOrderStatus(): void
{
$value = 'placed';
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\OpenAPIServer\\Model\\OrderStatus'),
\OpenAPIServer\Model\OrderStatus::PLACED
);
}
public function testParseParamsEnumPetStatus(): void
{
$value = 'available';
$this->assertEquals(
self::assertEquals(
parseParam($value, '\\OpenAPIServer\\Model\\PetStatus'),
\OpenAPIServer\Model\PetStatus::AVAILABLE
);
Expand Down
Loading