-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Java][MicroProfile] Support additionalProperties with Jackson #21451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for the PR do you mind filing a new one based on the latest master? I think your change was based on master when we were stuck with v7.14.0 release since last Thur. now the master refers to v7.15.0-SNAPSHOT version |
Done. 😃 |
| @@ -0,0 +1,12 @@ | |||
| generatorName: java | |||
| outputDir: samples/client/petstore/java/microprofile-rest-client-3.0-jackson-mutiny | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about adding this to the github workflow so that it will be tested moving forward?
| sb.append(" quantity: ").append(toIndentedString(quantity)).append("\n"); | ||
| sb.append(" shipDate: ").append(toIndentedString(shipDate)).append("\n"); | ||
| sb.append(" status: ").append(toIndentedString(status)).append("\n"); | ||
| sb.append(" complete: ").append(toIndentedString(complete)).append("\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we revert these change in the templates to keep the indentation?
|
thanks for the pr let's give it a try |
|
Hey @wing328, @joschi, isn't this a breaking change? Sometimes it was very desirable to have open-ended hashmap as a super interface for a set of objects. E.g. we were using it for "config" objects where some of the configurations are known and required (so we want to explicitly document them in the schema), but others' may come in a free-form format. |
When
additionalPropertiesis set totrue, use anadditionalPropertiesattribute and@JsonAnySetterand@JsonAnyGetterannotations instead of extendingHashMap.Refs #20853
Refs #20947
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg