-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Add cpp-oatpp-server generator (alpha) #21547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Jul 14, 2025
wing328
reviewed
Jul 14, 2025
Contributor
Author
|
@wing328 thanks for the suggestions, and good catch on adding the workflow because oat++ doesn't package a .pc file and I had to make tweaks to the cmake to get it working on Windows. |
Member
|
👍 let's give it a try thanks for contributing a new generator |
Member
|
fyi. merged #21569 as a follow up PR with minor improvements |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know what the process is here for dealing with old issues, but I messaged in slack a day ago about this, and knocked an MVP out in that time, so I felt like seeing if there was interest in upstreaming this.
Original PR #7903
I have myself marked as the maintainer. I could go either way here. I have intentions on adding more to this in the future (I'm doing this for work as a skunkworks project right now). I also have interest in adding the client when I end up running into a need for it.
I intentionally did not implement anything in https://oatpp.io/docs/modules/oatpp-swagger/, nor did I break out multi-part form data. I can do both if the need arises, but I needed to meet a very strict deadline for a customer and those weren't necessary right now.
I originally wrote this for 7.0.0 (as that's what I target internally), there were only a few minor changes to the class to make this work on main.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08) @aminya (2025/05)