-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Added cpp httplib server codegen #21672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @wing328, |
|
thanks for contributing a new generator can you please a github workflow and samples generated from the new generator similar to what we did in https://github.com/OpenAPITools/openapi-generator/pull/21547/files ? |
71898ed to
654865b
Compare
|
Hello @wing328, Thank you. |
542a3c5 to
178f105
Compare
|
Hello @wing328, Thank you. |
|
can you please review the build failure when you've time? |
178f105 to
9c31b68
Compare
| org.openapitools.codegen.languages.TypeScriptInversifyClientCodegen | ||
| org.openapitools.codegen.languages.TypeScriptJqueryClientCodegen | ||
| org.openapitools.codegen.languages.TypeScriptNestjsClientCodegen | ||
| org.openapitools.codegen.languages.TypeScriptNestjsServerCodegen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Will check. It is not intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
please also merge the latest master into your branch when you've time.
83d2f80 to
40e36af
Compare
40e36af to
8874df4
Compare
Introduces:
To close #21466
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)