Skip to content

Conversation

@davidgamero
Copy link
Contributor

@davidgamero davidgamero commented Aug 13, 2025

update @types/node from 12 to 16.

considering the current node LTS is 22, it would be helpful to enable using newer built-in types over older polyfill-based solutions without jumping too many versions at once to catch upgrade issues

i've added an explicit version of @types/node in favor of *, but would appreciate feedback on if that's a good idea

@types/node was pinned to node 12 by previous peer dependency on node-fetch 2.6.0, upgrading to 2.7.0 allows us to use the AbortSignal built-in type

update form-data to match version from #21748 in default tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

@davidgamero davidgamero changed the title use built in abortsignal WIP [typescript'] use built in abortsignal Aug 13, 2025
@davidgamero davidgamero changed the title WIP [typescript'] use built in abortsignal WIP [typescript] use built in abortsignal Aug 13, 2025
@davidgamero davidgamero marked this pull request as ready for review August 18, 2025 18:00
@davidgamero davidgamero changed the title WIP [typescript] use built in abortsignal WIP [typescript] use built-in abortsignal Aug 18, 2025
@davidgamero davidgamero changed the title WIP [typescript] use built-in abortsignal [typescript] use built-in abortsignal Aug 18, 2025
@macjohnny macjohnny merged commit d06ed32 into OpenAPITools:master Aug 19, 2025
18 checks passed
@wing328 wing328 added this to the 7.15.0 milestone Aug 22, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
* use built in

* upgrade types from pinned fetch

* samples

* csharp samples

* merge master and samples

---------

Co-authored-by: David Gamero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants