[protobuf] fix generation of enums with UNSPECIFIED values #21774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Aug 27, 2025
| * $ref: '#/components/schemas/Pet' | ||
| * In this case, the second allOf that defines a map with string keys and Pet | ||
| * values will be part of model's property. | ||
| */ |
Member
There was a problem hiding this comment.
thanks for the pr
can we keep the same yaml format before to show the example?
Contributor
Author
There was a problem hiding this comment.
Hey, sure! Thanks for the comment :) I will fix the formatting, I messed it up and it makes it harder to review. I will fix it today!
wing328
reviewed
Aug 27, 2025
| enumVars.add(0, unspecified); | ||
| boolean unspecifiedPresent = enumVars.stream() | ||
| .anyMatch(e -> { | ||
|
|
Member
There was a problem hiding this comment.
minor suggestion: remove this blank line
Contributor
Author
There was a problem hiding this comment.
It should be all good now @wing328, thank you!
leogomes-1a
force-pushed
the
fix-unspecified-protobuf
branch
3 times, most recently
from
a24f507 to
2ed9356
Compare
leogomes-1a
force-pushed
the
fix-unspecified-protobuf
branch
from
2ed9356 to
759c4d2
Compare
Member
|
thanks. let's give it a try |
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a default UNSPECIFIED value (introduced here), if an UNSPECIFIED enum value is already present the generator currently duplicates the UNSPECIFIED enum value, generating broken code. This PR fix that by simply checking if an UNSPECIFIED enum value is already present and only adding one if it's not yet defined.
@wing328 and @lucy66hw FYI :)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)